Improvement to process.py logging #2005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
LGTM, what about you @kevoreilly ? |
Owner
|
I've just tested it and seen that the log spamming that apparently prompted me to disable the |
Owner
|
If we can quiten these messages down to an 'acceptable' level then I think it should be ok. |
rkoumis
force-pushed
the
additional-analyzer-tests
branch
from
537f369 to
46ea175
Compare
Log the image name as well as the process ID; added tests. Also, restore the process is_alive check, disabled 4 years ago. Consequently, commented out excessive logging. Credit: @nbargnesi
rkoumis
force-pushed
the
additional-analyzer-tests
branch
from
46ea175 to
ac79838
Compare
Contributor
Author
|
I've commented out the verbose / spammy logging, @kevoreilly @doomedraven I squashed the commits back down to one, and now I realize I probably shouldn't have, sorry. Anyhow, that's what I did. Let me know if any questions. |
Collaborator
|
im not having time right now to test, was you able to test @kevoreilly latest commit? if no i will do that in 1-2 days |
Owner
|
Yep I'll test it tomorrow |
Contributor
Author
|
no rush but please take another look when you get a chance |
Owner
|
I've been running this on my main server for the last few days - I just need to check the logs. |
Owner
|
I wonder if this line is ok: Is |
rkoumis
commented
Mar 15, 2024
Contributor
Author
|
The new def __str__(self):
"""Get a string representation of this process."""
image_name = self.get_image_name() or "???"
return f"<{self.__class__.__name__} {self.pid} {image_name}>" |
Owner
|
Thank you! |
kevoreilly
added a commit
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log the image name as well as the process ID; added tests.
Also, restore the process is_alive check, disabled 4 years ago.
Credit: @nbargnesi
Sample log entries: